[Kamailio-Devel] [SR-Dev] [PATCH 1/8] Define OPENSER_MOD_INTERFACE in Makefile.

Jan Janak jan at iptel.org
Tue Mar 3 14:26:43 CET 2009


On 03-03 13:51, Andrei Pelinescu-Onciul wrote:
> On Mar 03, 2009 at 13:01, Henning Westerholt <henning.westerholt at 1und1.de> wrote:
> > On Tuesday 03 March 2009, Jan Janak wrote:
> > > This patch adds -DOPENSER_MOD_INTERFACE to the modules Makefile, this
> > > is needed to make Kamailio modules compile with the sip router core.
> > 
> > Hi Jan,
> > 
> > thank you for the patches, i've commited them to master. The only remaining 
> > error (after /lib/kcore/km_crc was merged) is some incompatiblity with the 
> > LM_GEN1 macro from dprint.h.
> 
> 
> Just for future reference:
> 
> Patch series like Jan sent, can be very easily applied with git am.
> So instead of applying them by hand you could save them into a separate
> mailbox (e.g. jan_patches_1) and then run git am on that mailbox,
> e.g.: git am -s ~/jan_patches_1 
> This would apply all the patches saved in the mailbox and will use the
> mail body as commit message.
> 
> -s is optional, it adds a Signed-off-by: commiter name to the commit
> message.
> 
> Also patches like Jan sent are created using git format-patch. You
> basically give it a commit range and it would generate mail-ready
> patches.

Yes, also I keep those commits in a local repository which I intend to publish
somehow somewhere soon. Then you could merge changes from the repository
easily. The main reason why I was sending the patches was to get some review
by people who know the code better than myself. 

  Jan.



More information about the Devel mailing list