[Kamailio-Devel] [ openser-Bugs-1948949 ] dialog: BYE2BYE Patch #1642890 not fully implemented in V1.3

[SourceForge.net]

Bugs item #1948949, was opened at 2008-04-22 18:50
Message generated for change (Settings changed) made by miconda
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1948949&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.3.x
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Jim Burke (jimbohamez)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: dialog: BYE2BYE Patch #1642890 not fully implemented in V1.3

Initial Comment:
After installing Openser Version 1.3 I found that the BYE2BYE patch submitted by EKobi was only partially implemented in the DIALOG module.

The dialog module has been changed and a way to send 'BYE' messages to both caller and callee via the MI_FIFO module were added, however no code was added in the procedure to handle timeouts.  Refer to openser/modules/dialog/dlg_handlers.c procedure dlg_ontimeout.

The BYE2BYE patch also added the following parameters that allow the script to process the BYE messages for billing purposes.

modparam("bye2bye","bye2bye_to_next_hop","sip:mydomain.com:5060")
modparam("bye2bye","bye2bye_from_next_hop","sip:mydomain.com:5060")

Regards,
Jim

----------------------------------------------------------------------

Comment By: Jim Burke (jimbohamez)
Date: 2008-05-11 06:37

Message:
Logged In: YES 
user_id=1986627
Originator: YES

Hi Bogdan,

I understand your concerns based on the RFC.  We have the URI set to our
own server IP address, thus it allows the BYEs generated at timeout to be
processed via the script.  In doing so I don't think the way we are
breaking the intention of the RFC.  Perhaps the description of the parms
are somewhat misleading in that it suggests you can send the BYE to another
UAS to be processed.  

One other thing for V1.4 development.  Will the user have the ability to
set the timeout value via on-reply route?  In the case of CANCEL/200 race
condition it would be helpfull to send a BYE to the callee.  We have had a
situation were the CANCEL has arrived from the caller and we have stopped
billing, at the same time a 200 with SDP arrived from the PSTN wholesaler. 
They billed us from the answer to timeout on there end.

Am happy to close this ticket based on your response.

Regards,
Jim    


----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-05-11 00:49

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Jim,

That part of the patch was not included as it breaks the RFC3261 - a
request within the dialog must be routed according the the routing set (RR
+ contact) and all proxies on the patch must respect this - so, if openser
generates a request within the dialog, it must follow this rule too and not
force different destinations for the messages.

A different solution to achieving the same functionality will be on the
way for 1.4

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1948949&group_id=139143