[Kamailio-Devel] [ openser-Bugs-2727929 ] bugs in DNS EBL parser

[SourceForge.net]

Bugs item #2727929, was opened at 2009-04-03 08:20
Message generated for change (Tracker Item Submitted) made by henningw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2727929&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Henning Westerholt (henningw)
Assigned to: Nobody/Anonymous (nobody)
Summary: bugs in DNS EBL parser

Initial Comment:
Reported from Andrei:

[...]

BTW: there seem to be 2 small bugs in the k code:

dns_ebl_parser(...):

1.
    len = *rdata;
    ^^^^^^^^^^^^ this is the position and not the len
    if (rdata + 1 + len >= end)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^ len being the position this is useless
   it should be something like:
    if (((rdata+4)>end)||((rdata+1+1+rdata[1]+2)>end)) goto error;
   (4 being the minimum size for an ebl and the other expression
     being ebl with minimum apex)

2.
    ebl->apex_len=dn_expand(msg, end, rdata, ebl->apex, MAX_DNS_NAME-1);
           ^^^^^^^^^ dn_expand returns the compressed len so this should
                     be replaced by ebl->apex_len=strlen(ebl->apex).


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2727929&group_id=139143