[Kamailio-Devel] [ openser-Bugs-2091025 ] wrong error handling in dialog module

[SourceForge.net]

Bugs item #2091025, was opened at 2008-09-03 14:16
Message generated for change (Settings changed) made by klaus_darilion
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2091025&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Klaus Darilion (klaus_darilion)
>Assigned to: Klaus Darilion (klaus_darilion)
Summary: wrong error handling in dialog module

Initial Comment:
Hi!

In dlg_handlers.c dlg_onreply():

        /* get to tag*/
        if ( !rpl->to && ((parse_headers(rpl, HDR_TO_F,0)<0) || !rpl->to) ) {
            LM_ERR("bad reply or missing TO hdr :-/\n");
            tag.s = 0;
            tag.len = 0;
        }
        tag = get_to(rpl)->tag_value;

If parsing of to header fails, the get_to() macro is still executed.



----------------------------------------------------------------------

Comment By: Klaus Darilion (klaus_darilion)
Date: 2008-09-03 14:21

Message:
Logged In: YES 
user_id=1318360
Originator: YES

ACtually I am not sure anymore if this is a bug - I think calling the
macro is safe. Nevertheless it does not make sense.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2091025&group_id=139143