[Kamailio-Devel] append_branch() inside modules

Iñaki Baz Castillo ibc at aliax.net
Fri Nov 28 10:51:35 CET 2008


El Viernes, 28 de Noviembre de 2008, Klaus Darilion escribió:
> regarding other branch parameters which were not copied
> (duri, send_socket, bflags ...) - this should be reviewed too.

Why should be bflags copied when appending a new branch manually?

PD: As a suggestion, what I don't like is the possibility of handling bflags 
out of branch_route. It causes confussion, for example:
- User registered in two location, one natted and one not natted.
- If we check the bflag(NATTED) in a route block we can get 1 or 0 depending 
on which location appears first in the location table (or memory).

So, I suggest to just allow functions setbflag(), isbflagset(), 
resetbflag()... in branch_route and onreply_route. Does it make sense? could 
it break something? (well, sure it can break malfored scripts using bflags on 
route blocks).

-- 
Iñaki Baz Castillo



More information about the Devel mailing list