[OpenSER-Devel] concurrency issues in lcr

[Juha Heinanen]

Dan Pascu writes:

 > This line in reload_gws() is not atomic:
 > 
 >     (*lcrs_ws_reload_counter)++;
 > 
 > An atomic counter should be used for that, otherwise the value of 
 > lcrs_ws_reload_counter may end up with the wrong value if 2 concurrent 
 > processes modify it in a narrow time window.

dan,

this is a known issue and the same holds true for reloading domains in
domains module, where it is even documented.  a lock was not used
because it was thought that reloads are result of human action and
therefore are not likely to happen simultaneously.

-- juha