[OpenSER-Devel] [ openser-Bugs-1963639 ] In-dialog request clobbers Dialog module timer value

[SourceForge.net]

Bugs item #1963639, was opened at 2008-05-14 00:51
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1963639&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.2.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Kobi Eshun (ekobi)
Assigned to: Nobody/Anonymous (nobody)
Summary: In-dialog request clobbers Dialog module timer value

Initial Comment:
The dlg_onroute() callback invokes update_dlg_timer() when a "sequential request is successfully processed." There are two problems with this:

1 - It defeats the purpose of using the dialog timeout as a watchdog to limit call duration. Does it make sense to optionally suppress updates to the dialog timer? 

2 - the timer is updated with a value read from the timeout AVP. Unfortunately, the AVP is at best only transaction stateful, and thus (generally) undefined for sequential requests. As a result, the default timeout parameter is used instead (12 hours by default). Presumably the value from the timeout AVP needs to be cached in dialog-persistent memory for this to work as might be expected.

This problem exists in versions 1.2 through HEAD. Cheers,
--
kobi


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1963639&group_id=139143