[OpenSER-Devel] [ openser-Patches-1931415 ] oracle database driver module

[SourceForge.net]

Patches item #1931415, was opened at 2008-04-01 16:10
Message generated for change (Comment added) made by henningw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1931415&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Henning Westerholt (henningw)
Assigned to: Henning Westerholt (henningw)
Summary: oracle database driver module

Initial Comment:
Iouri Kharon, yjh at styx dot cabel dot net, created a new database module, for native oracle access.

This code was reviewed in the past weeks from me, and a few smaller issues were already fixed from us.

Integration of this driver into the code means that a few colum names needs to be changed (reserved names in Oracle), but only module that needs an actual change in the code is siptrace.

Also necessary was the change of one query statement in usrloc for the nathelper/ mediaproxy interface, as oracle don't provide the neccessary functions.


It comes with an openserctl and openserdbctl interface, additional to this there are also some admin tools provided. To compile the code a SDK from oracle, which is free available for download, is needed.

Iouri is willing to maintain the code in our repository at least for one year.


Remaining issues:

1. Bug in openserdbctl create (MySQL):

ERROR 1418 (HY000) at line 1: This function has none of DETERMINISTIC, NO SQL, or READS SQL DATA in its declaration and binary logging is enabled (you *might* want to use the less safe log_bin_trust_function_creators variable)

2. Licence of development headers:

The code of the oracle SDK is probably not GPL compatible. This means that this also probably not compatible with Debian, make it necessary to create  another src file for distribution, openser-oracle.tar.gz or something like this. Help of someone with more Debian knowledge is appreciated.

3. SQL schemes
At the moment some manually created SQL schemes are provided, this needs to converted to the XSL infrastructure.


Please review! Best regards,

Henning

----------------------------------------------------------------------

>Comment By: Henning Westerholt (henningw)
Date: 2008-05-08 14:11

Message:
Logged In: YES 
user_id=337916
Originator: YES

XSL infrastructure is ready, SQL for oracle is updated. Close this patch.

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2008-04-16 16:11

Message:
Logged In: YES 
user_id=337916
Originator: YES

The oracle driver was commited to trunk, also most of the XSL
infrastructure is now in place.

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2008-04-03 16:49

Message:
Logged In: YES 
user_id=337916
Originator: YES

The SQL scheme update and usrloc changes are already commited, db_oracle
specific parts can be found in the new patch attached.

Henning
File Added: db_oracle-3.patch.gz

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2008-04-02 09:03

Message:
Logged In: YES 
user_id=337916
Originator: YES

Hi Daniel,

yes, there were a compatibility function added to the MySQL control
script, similar to the ones we already have for postgres, as there are
quite a few MySQL specific calls in the code.

Thanks,

Henning

----------------------------------------------------------------------

Comment By: Daniel-Constantin Mierla (miconda)
Date: 2008-04-02 07:25

Message:
Logged In: YES 
user_id=1246013
Originator: NO

the patch for sip trace is ok -- the column names can be changed via
parameters is one sticks to the old name for different db types.

I am not sure about the patch to usrloc, the functions used in the query
are oracle specific, didn;t check if you added them in mysql, are they?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1931415&group_id=139143