[OpenSER-Devel] [ openser-Patches-1951508 ] add outbound CRLF ping-pong

[SourceForge.net]

Patches item #1951508, was opened at 2008-04-25 13:25
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1951508&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: ver devel
>Status: Closed
Resolution: Accepted
Priority: 9
Private: No
Submitted By: Klaus Darilion (klaus_darilion)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: add outbound CRLF ping-pong

Initial Comment:
Hi!

I have ported outbound CRLF ping pong (client sends CRLFCRLF (ping) and server answers with (CRLF (pong)) from ser to openser.

Code was added to ser (c) by Alfred E. Heggestad

I have modified some variables for an IMO better naming.

To activate set 
  tcp_crlf_pingpong=1
in openser.cfg. I have tested it and it works fine for me.

default:   tcp_crlf_pingpong=0 (like current behavior)

please review


----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-05-07 23:09

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Klaus,

I applied the patch on SVN with one change: the tcp_crlf_pingpong param is
by default on and not off as per initial patch. As enabling this
functionality does not require any special action from openser side, it is
better to be on in case a client sends the TCP ping.

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-05-07 18:45

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Inaki,

It is scheduled for this week, so stay tune ;).

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Iñaki Baz (ibc_sf)
Date: 2008-05-07 18:40

Message:
Logged In: YES 
user_id=1844020
Originator: NO

Hi, please Bogdan, tell us when you decide to submit this patch. I'm
interested in it :)

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-04-28 23:55

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Klaus,

Thanks for extracting the patch - i will do a fast review before applying
it. It think this is something good to have in 1.4 ;).

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1951508&group_id=139143