[OpenSER-Devel] [OpenSER-Users] OpenSER 1.3.1 is released

[Jan ONDREJ (SAL)]

On Fri, Mar 14, 2008 at 12:04:44PM +0100, Bastian Friedrich wrote:
> Hi,
> 
> On Friday 14 March 2008, Bogdan-Andrei Iancu wrote:
> > Jan ONDREJ (SAL) wrote:
> > > ===================
> > >
> > > For perl 5.10 this patch is required:
> >
> > Regarding the perl patch - Bastian (here CCed) is the maintainer of the
> > module. But is this fix? if so, what is the problem?
> 
> A patch for Perl 5.10 compatibility is included in
> - OpenSER 1.3.1 (as released)
> - SVN branch 1.3
> - SVN branch 1.2
> - SVN trunk
> 
> The "old" code (PERL_SYS_INIT3(&argc, &argv, &environ)) was replaced with a 
> new "PERL_SYS_INIT3(NULL, NULL, &environ)". You are suggesting using the 
> macro PERL_SYS_INIT3_BODY instead of the current version (which eventually 
> results in a new function call to Perl_sys_init3 in Perl 5.10.0). This is not 
> the desired/encouraged/correct behavior.
> 
> I.e., I frankly do not understand what problem you encounter.

This patch has been done not by me. I don't know anything about perl.

> The log file you have published at
>   http://koji.fedoraproject.org/koji/getfile?taskID=501231&name=build.log
> shows a build of 1.3.0, not 1.3.1...?

Right.

After removing the patch, build is OK.
You can see build log here:
  http://koji.fedoraproject.org/koji/getfile?taskID=516422&name=build.log

Thank you for your answer.

		SAL