[OpenSER-Devel] [ openser-Patches-1872331 ] dialog: get_direction() api enhancement

[SourceForge.net]

Patches item #1872331, was opened at 2008-01-15 21:29
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1872331&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ovidiu Sas (osas)
>Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: dialog: get_direction() api enhancement

Initial Comment:
Sometimes, modules that are sitting on top of the dialog module needs to know the direction of a message (upstream or downstream).

The following patch will enhance the dialog callback api with get_direction() function.

The prototype:
unsigned int get_direction(struct dlg_cell *dlg, struct sip_msg* msg);

and it will return one of the following values:
DLG_DIR_UPSTREAM    # the direction of the initial INVITE
DLG_DIR_DOWNSTREAM  # the direction of the first reply
DLG_DIR_NONE        # in case of an error


----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-03-03 17:34

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Ovidiu,

I delayed a bit the patch as I wanted to re-work it a bit - I think it is
not really necessary to detect the direction at each function call, as the
direction is detected at match time. So, more or less we just need to
remember the direction :)

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-03-01 19:30

Message:
Logged In: YES 
user_id=1395524
Originator: YES

If there are no objections, I will push this patch in next week.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1872331&group_id=139143