[OpenSER-Devel] returning 0 from function

Henning Westerholt henning.westerholt at 1und1.de
Mon Mar 3 11:16:22 CET 2008


On Monday 03 March 2008, Juha Heinanen wrote:
> Dan Pascu writes:
>  > AFAIK, there are functions in tm that rely on this, including t_relay if
>  > I'm not mistaken. I'd say that until a list of the module functions that
>  > use this behavior is made so we can draw a conclusion, it's premature to
>  > assume this will be easy to change, or that is even possible to give up
>  > on the behavior without major code restructuring.
>
> in my openser.cfg i do call exit also after t_relay.  i think is it is
> very bad programming practice to relay certain functions to exit the
> script implicitly.  in my opinion, no module function should cause the
> script to exit.  it should be always the decision of script writer.

Hi Juha,

yes, i've also the same opinion. But there will be probably many configs out 
there that do rely on this behaviour, and will break if we change this. So i 
also think this is not something that we should treat lightly.

Cheers,

Henning



More information about the Devel mailing list