[OpenSER-Devel] [ openser-Bugs-1890852 ] [presence] Change "totag_avpid" to allow any AVP

[SourceForge.net]

Bugs item #1890852, was opened at 2008-02-11 02:59
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1890852&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
>Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Iñaki Baz (ibc_sf)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: [presence] Change "totag_avpid" to allow any AVP

Initial Comment:
Actually (if I'm not wrong) "presence" module has a parameter "totag_avpid" that is the only parameter in any module that askes for an AVP numeric id.

This is:
  modparam("presence", "totag_avpid", 28)
means that "presence" will use AVP(i:28) for its purposes.

Any other module using AVP's allows choosing any kind of AVP, not just numeric. Examples:
  modparam("tm", "fr_inv_timer_avp", "$avp(i:39)")
  modparam("auth", "rpid_avp", "$avp(s:rpid)")
  modparam("registrar", "received_avp", "$avp(i:66)")
  modparam("cpl-c","timer_avp","$avp(i:39)")

Why should "presence" be different?

I propose to change "totag_avpid" to be like the other similar parameters:
  modparam("presence", "totag_avpid", "$avp(i:28)")

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-03-03 11:16

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Checked with Anca - parameter is not used, so I just removed it.

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-29 12:19

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Inaki,

While investigating this issue, I discovered that this param is not even
used anymore, so I simple removed it from presence module.
Before doing any backport, I will doublecheck with Anca, the developer of
the presence module, to be sure that my understanding is correct. 

Thanks and regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1890852&group_id=139143