[OpenSER-Devel] SF.net SVN: openser: [4362] trunk/modules

[Bogdan-Andrei Iancu]

Hi Dan,

I took into consideration also the fact that an INVITE opening a dialog 
to need media relay. Cases:
    1) Invite points to a natted destination
    2) Invite is generated by an external AS (like sems) which (re-using 
some received SDP) may require contact and SDP fixing also

Normally, I agree, you should not need NAT traversal support for 
locally-generated requests, but there can be some corner cases where you 
need it, so I enabled the functions not to have any kind of limitations.

regarding client_nat_test - the nat test is also based on SDP IP, which 
is can be provided via MI, so , it can be private (integration with some 
AS).

Regards,
Bogdan

Dan Pascu wrote:
>
> Bogdan,
>
> these changes make little sense. Only end_media_session makes sense 
> for the local_route.
> use_media_proxy makes little sense as the generated request is only 
> BYE at the moment (which should call end_media_session).
> fix_contact and client_nat_test also do not make sense to be called in 
> the local_route as the origin is the proxy itself, which is neither 
> behind NAT, nor has a NAT-ed contact to fix.
>
> Bogdan-Andrei Iancu wrote:
>> Revision: 4362
>>           http://openser.svn.sourceforge.net/openser/?rev=4362&view=rev
>> Author:   bogdan_iancu
>> Date:     2008-06-10 07:53:47 -0700 (Tue, 10 Jun 2008)
>>
>> Log Message:
>> -----------
>> - nat traversal functions may be called from LOCAL_ROUTE
>>
>> Modified Paths:
>> --------------
>>     trunk/modules/mediaproxy/mediaproxy.c
>>     trunk/modules/nat_traversal/nat_traversal.c
>>     trunk/modules/nathelper/nathelper.c
>>
>>
>> This was sent by the SourceForge.net collaborative development 
>> platform, the world's largest Open Source development site.
>>
>> _______________________________________________
>> Devel mailing list
>> Devel at lists.openser.org
>> http://lists.openser.org/cgi-bin/mailman/listinfo/devel
>>   
>
>