[OpenSER-Devel] [ openser-Feature Requests-1989917 ] t_relay(proto:host:port) ignores the parameter if $du is set

[SourceForge.net]

Feature Requests item #1989917, was opened at 2008-06-10 15:38
Message generated for change (Comment added) made by henningw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743023&aid=1989917&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Anatoly Pidruchny (apidruchny)
Assigned to: Nobody/Anonymous (nobody)
Summary: t_relay(proto:host:port) ignores the parameter if $du is set

Initial Comment:
If $du (dst_uri in sip_msg structure) is set then t_relay ignores the proto:host:port parameter and sends the message to the $du destination. Logically, it should be wrong for a function to ignore its parameter and use some value that was set elsewhere earlier.

It is not really clear from documentation if the parameter of t_relay has higher priority then $du. But, as discussed on the OpenSER users list, at least one user agree with me that the parameter of t_relay, if provided, has to be respected. Nobody expressed an opinion that the parameter has to be disrespected if $du is set.

----------------------------------------------------------------------

>Comment By: Henning Westerholt (henningw)
Date: 2008-07-08 14:54

Message:
Logged In: YES 
user_id=337916
Originator: NO

Hi,

i've added a short note to the respective section in the module
documentation about this behaviour.

Henning

----------------------------------------------------------------------

Comment By: Daniel-Constantin Mierla (miconda)
Date: 2008-07-08 14:18

Message:
Logged In: YES 
user_id=1246013
Originator: NO

I believe this is more a feature request than a bug -- it is like who has
the power, the rfc or the admin, I also find it more natural to follow the
parameter, but I don't see it as a bug right now -- moving it accordingly.

----------------------------------------------------------------------

Comment By: Iaki Baz (ibc_sf)
Date: 2008-06-10 16:50

Message:
Logged In: YES 
user_id=1844020
Originator: NO

SIP loose routing mechanism tells that a request must be forwarded to the
top "Route" location regardless of the RURI value.
Even if we change the RURI (using 'rewritehost' or '$ru/$rU/$rd=') the
request would be sent to the location indicated in top "Route" header if we
do "loose_route()".

But if we do "t_relay('NEW_IP:NEW_PORT')", what are we setting?
Obviously we are not changing the RURI when doing it, so what?
IMHO what this parameter must set is the real destination ($du) even if it
has been already set via "loose_route()" or manually.

So I agree that using "t_relay()" with a parameter should set the real
destination and overwrite any previous $du value (if set). Giving priority
to the already set $du over the "t_relay()" parameter is confusing and
doesn't make sense (IMHO).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743023&aid=1989917&group_id=139143