[OpenSER-Devel] SF.net SVN: openser: [3506] trunk

Henning Westerholt henning.westerholt at 1und1.de
Mon Jan 7 14:33:26 UTC 2008


On Monday 07 January 2008, Henning Westerholt wrote:
> Revision: 3506
>           http://openser.svn.sourceforge.net/openser/?rev=3506&view=rev
> Author:   henningw
> Date:     2008-01-07 06:26:27 -0800 (Mon, 07 Jan 2008)

Hi Norman,

this commit removes your change to the postgres driver in rev 1220:

* 2006-11-01 Updated pg_insert(), pg_delete(), pg_update() and  
* pg_get_result() to handle failed queries.  Detailed warnings along with the  
* text of the failed query is now displayed in the log.
* Callers of these routines can now assume that a non-zero rc indicates
* the query failed and that remedial action may need to be taken. (norm)

Should we implement this also for the other drivers? Also you changed the 
postgres implementation to returns a positive value in this case, are there 
any modules that evaluates this return code at all?

What do you think?

Cheers,

Henning



More information about the Devel mailing list