[OpenSER-Devel] [ openser-Documentation-1863419 ] carrieroute: incomplete documentation cr_user_rewrite_uri

[SourceForge.net]

Documentation item #1863419, was opened at 2008-01-03 20:49
Message generated for change (Comment added) made by henningw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=782960&aid=1863419&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.3.x
Status: Closed
Resolution: Invalid
Priority: 5
Private: No
Submitted By: Ovidiu Sas (osas)
Assigned to: Henning Westerholt (henningw)
Summary: carrieroute: incomplete documentation cr_user_rewrite_uri

Initial Comment:
cr_user_rewrite_uri function can accept an avp as a second parameter.  The documentation should reflect this along with an example.

Also, if there are other functions that are accepting avps, those ones should be documented as well.



Regards,
Ovidiu Sas

----------------------------------------------------------------------

>Comment By: Henning Westerholt (henningw)
Date: 2008-01-07 11:33

Message:
Logged In: YES 
user_id=337916
Originator: NO

Hi OVidiu,

yes, at the moment you need to create several failure_route blocks. But we
have some extensions in the work to remove this limitation, to make the
routing with cr more flexible.. But i can't provide that much details about
this currently, at the implementation is not finished yet. ;-)

And yes, you need to call append_branch() in the failure route if you use
any rewriting function of cr.
This is consistent to 'normal' failure_route behaviour, i think. 

The cr module writes the new URI into RURI (branches[0]). Then
append_branch()
copies the URI from branches[0] into branches[1]. Then t_relay sees 2
branches:
branches[0] and branches[1]. But as branches[0] is already "dead", only
branches[1]
will be relayed. (to quote from the mailing list)

Cheers,

Henning

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-01-04 20:31

Message:
Logged In: YES 
user_id=1395524
Originator: YES

Hi Henning,

My bad for opening the bug without double checking first.  Indeed, the
cr_user_rewrite_uri function does not accept avp as a domain parameter.

Just for clarification, if I need to failover several times, I will need
to create several failure_route blocks, right?  And I need to know a priori
the domains.

Also, it seems that I need to call append_branch() when I do a failure
using cr_tree_rewrite_uri.  Is this the expected way of working?


Regards,
Ovidiu Sas

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2008-01-04 12:22

Message:
Logged In: YES 
user_id=337916
Originator: NO

Hi Ovidiu,

why do you think that it accept a AVP as the domain parameter? I don't
think so.
This is also not so easy to implement at the moment, as the domain is
added in
the fixup function on config file loading.

The two functions that accepts PVs as first parameter states this also in
the
documentation.

Cheers,
Henning

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=782960&aid=1863419&group_id=139143