[OpenSER-Devel] [ openser-Bugs-1855793 ] Invalid cseq-number when using fifo dlg_end_dlg

[SourceForge.net]

Bugs item #1855793, was opened at 2007-12-21 17:40
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1855793&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.3.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Carsten Bock (carstenbock)
>Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: Invalid cseq-number when using fifo dlg_end_dlg

Initial Comment:
Hi,

the dialog-module creates an incorrect cseq number for the created bye-messages, when using the new fifo command dlg_end_dlg. The cseq number is increased in the file modules/dialog/dlg_req_within.c (method "build_dlg_t") and then again in the file modules/tm/uac.c (method "req_within"). The RFC says, the cseq MUST be incremented by one. We found a device in our network, which takes this very stricty and ignores the request.
Attached Patch against OpenSER 1.3 (SVN) fixes this tiny issue.

Carsten

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-01-04 17:59

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Carsten,

Thanks for the report and fix - I will overview it and upload it on SVN.

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Carsten Bock (carstenbock)
Date: 2007-12-21 19:23

Message:
Logged In: YES 
user_id=1488991
Originator: YES

Hi,

i also just noticed another tiny issue regarding the cSEQ: Always the cSEQ
of the Callee was used.
Here's another patch fixing both issues regarding the cSEQ-Number!

Happy holidays and merry christmas!

Carsten
File Added: dialog.patch

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1855793&group_id=139143