[OpenSER-Devel] [ openser-Bugs-1903558 ] Openserctl with unixsock has errors

[SourceForge.net]

Bugs item #1903558, was opened at 2008-02-28 02:19
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1903558&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: tools
Group: ver devel
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Sergio Gutierrez (saguti)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: Openserctl with unixsock has errors

Initial Comment:
The openserctl unixsock interface has three missed functions, which cause the script fails and do not report statistics.

A patch with a fix is attached.

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-29 11:43

Message:
Logged In: YES 
user_id=1275325
Originator: NO

OK - fix pushed on trunk, 1.3 and 1.2

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-29 11:29

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Sergio,

I it looks ok - I will commit it to SVN.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-28 21:04

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Sergio,

I will take a look at this patch and if ok, I will apply it on SVN.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Sergio Gutierrez (saguti)
Date: 2008-02-28 16:40

Message:
Logged In: YES 
user_id=1960760
Originator: YES

Hi Bogdan.

I am sending another patch, following an approach similar to
openserctl.fifo; I use the internal function unixsock_cmd to fetch the
statistics.

Please let me know if it is fine.

Thanks and regards.

Sergio Gutierrez
File Added: openserctl.unixsock.patch

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-02-28 11:30

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Sergio,

the patch does not really fix the problem. If you look in openserctl.fifo,
the fifo_openser_monitor() doe not use anymore the XX_stats() functions,
but it implements a different approach in fetching the statistics.
Could you update openserctl.unixsock to implement the same approach?

Thanks and regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1903558&group_id=139143