[OpenSER-Devel] [ openser-Patches-1870857 ] new module: ratelimit

[Carsten Bock]

Hi all,

i would vote for keeping them separate. Basically, because i think the
purpose of both modules is quite different (avoiding DOS-Attacks vs.
Traffic shaping).

Just my 0.02$,
Carsten


Am Dienstag, den 12.02.2008, 20:25 -0500 schrieb Ovidiu Sas:
> The idea is to bundle similar functionality:
>  - pike - limiting based on source IP (suitable for DoS attacks);
>  - ratelimit - limiting based on method and/or load and/or user
> defined criteria (suitable for traffic shaping control and server load
> control).
> 
> The README for ratelimit can be found here: http://pastebin.ca/899983
> The README for pike can be found here:
> http://www.openser.org/docs/modules/devel/pike.html
> 
> 
> PROS:
>  - bundle somehow related functionality;
>  - less modules to maintain.
> CONS:
>  - cluttered README file and init params;
>  - ugly definition for timers (each module has it's own timer and we
> need to keep them separately);
>  - no code shared so far.
> 
> 
> In the end: "Vox populi, vox dei" :-)
> 
> 
> Regards,
> Ovidiu Sas
> 
> 
> On Feb 12, 2008 4:30 PM, Christian Schlatter <cs at unc.edu> wrote:
> > Ovidiu Sas wrote:
> > > It seems that this module doesn't present enough interest for the community :)
> >
> > It's not that the module isn't interesting, in fact I think this is a
> > very handy rate limiting tool. It is more that I don't care that much if
> > it should be merged with pike or not. I'd need to have a look at the
> > code of these two modules in order to decide this question. Would there
> > be any code synergies or is the idea to bundle similar functionality
> > into one module?
> >
> > /Christian
> >
> >
> > >
> > >
> > > Cheers,
> > > Ovidiu
> > >
> > > On Feb 11, 2008 7:03 AM, Henning Westerholt <henning.westerholt at 1und1.de> wrote:
> > >> On Friday 08 February 2008, SourceForge.net wrote:
> > >>>> Comment By: Ovidiu Sas (osas)
> > >>> Date: 2008-02-08 11:26
> > >>>
> > >>> Message:
> > >>> Logged In: YES
> > >>> user_id=1395524
> > >>> Originator: YES
> > >>>
> > >>> New tarball updated with the openims enhancements.
> > >> Have we reached an agreement about the merging of this module in the trunk?
> > >>
> > >> The votes so far
> > >>
> > >> - merging with pike: +2 (Bogdan, Henning)
> > >> - standalone module: +2 (Klaus, Ovidiu)
> > >>
> > >> Cheers,
> > >>
> > >> Henning
> > >>
> > >> _______________________________________________
> > >> Devel mailing list
> > >> Devel at lists.openser.org
> > >> http://lists.openser.org/cgi-bin/mailman/listinfo/devel
> > >>
> > >
> > > _______________________________________________
> > > Devel mailing list
> > > Devel at lists.openser.org
> > > http://lists.openser.org/cgi-bin/mailman/listinfo/devel
> >
> >
> > _______________________________________________
> > Devel mailing list
> > Devel at lists.openser.org
> > http://lists.openser.org/cgi-bin/mailman/listinfo/devel
> >
> 
> _______________________________________________
> Devel mailing list
> Devel at lists.openser.org
> http://lists.openser.org/cgi-bin/mailman/listinfo/devel