[OpenSER-Devel] [ openser-Feature Requests-1891163 ] db_postgres module enhancements

[SourceForge.net]

Feature Requests item #1891163, was opened at 2008-02-11 06:21
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743023&aid=1891163&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Henning Westerholt (henningw)
Assigned to: Nobody/Anonymous (nobody)
Summary: db_postgres module enhancements

Initial Comment:
There are some issues with the db_postgres which should be fixed for better performance and compatibility with recent drivers.

1. The modules copy STR and STRING values, this is unnecessary work. The code should be changed to work directly with the values returned from the driver, like the db_mysql module. After that change the complicated row_buffer logic could be simplified too.

For BLOB values the escape function does a copying, but as BLOBs are not that much used internally, this is not a real problem.

Issues around this problem were discussion in the thread at http://www.nabble.com/RFC:-memory-management-in-database-modules-td15291047.html

2. Postgres uses in recent driver versions a new escaping method for values. Thus the module should be changed to detect the new escaping method, and use them if needed.

This was discussed in the thread at
http://www.nabble.com/postgresql-and-escaping-p15065608.html

Cheers,

Henning

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2008-02-11 07:16

Message:
Logged In: NO 

> For BLOB values the escape function does a copying, but as 
> BLOBs are not that much used internally, this is not a real problem.

BLOBS are used by presence module (XML) - thus it may be an issue for
presence servers

-- 
klaus

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743023&aid=1891163&group_id=139143