[Kamailio-Devel] [ openser-Bugs-1979305 ] acc doesn't log multiple branches correctly

[SourceForge.net]

Bugs item #1979305, was opened at 2008-05-30 16:29
Message generated for change (Comment added) made by miconda
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1979305&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Invalid
Priority: 5
Private: No
Submitted By: Stanislaw Pitucha (viraptor)
Assigned to: Daniel-Constantin Mierla (miconda)
Summary: acc doesn't log multiple branches correctly

Initial Comment:
Is my current setup acc is not behaving correctly.

We do an enum_query(...) and then check all branches by using next_branches() in failure_route. When some route fails, and second one succeeds, we get this record in db:

missed_calls:
6 | INVITE | rh2fnt0vb9 | as4c730b64 | 3c51fa8a058d-xy15vv1od2qf | 404 | Not Found | 2008-05-30 13:03:31

acc:
10 | BYE | rh2fnt0vb9 | as192d5c2f | 3c51fa8a058d-xy15vv1od2qf | 200 | OK | 2008-05-30 13:03:33

Even though that call was connected in the end, it's split between missed and acc. Behaviour that we would actually like to see is what we get after commenting "reset_acc_flag( req, flags_to_reset );" in acc_logic.c:on_missed()

missed:
11 | INVITE | u6uqklawja | as489bf46e | 3c2a840c1c5d-auhvh69993ur | 404      | Not Found          | 2008-05-30 14:04:03

acc:
14 | INVITE | u6uqklawja | as0cf4c84f | 3c2a840c1c5d-auhvh69993ur | 200      | OK         | 2008-05-30 14:04:03
15 | BYE    | u6uqklawja | as0cf4c84f | 3c2a840c1c5d-auhvh69993ur | 200      | OK         | 2008-05-30 14:04:07

So each failed branch gets it's own missed_calls entry and successes are logged correctly with both INVITE and BYE. I'd like to propose making this behaviour configurable with modparam.

----------------------------------------------------------------------

>Comment By: Daniel-Constantin Mierla (miconda)
Date: 2008-08-07 12:15

Message:
Logged In: YES 
user_id=1246013
Originator: NO

It is required to be a different flag for each case. I am closing this
now. If one considers that this should be changed to work with single flag,
then open a feature request.

----------------------------------------------------------------------

Comment By: Alex Hermann (axlh)
Date: 2008-08-07 12:03

Message:
Logged In: YES 
user_id=1212856
Originator: NO

I use the same flag value for all acc related flags. So if one is reset,
it resets all of them in my case.

----------------------------------------------------------------------

Comment By: Daniel-Constantin Mierla (miconda)
Date: 2008-08-07 11:26

Message:
Logged In: YES 
user_id=1246013
Originator: NO

Trying to reproduce this, but not luck for me. Are you using same flag to
mark transactions for accounting successful and missed calls? Can one send
me the config? It is easy to troubleshoot, the source code shows that in
on_missed() function only the log_missed_flag is reset.

----------------------------------------------------------------------

Comment By: Alex Hermann (axlh)
Date: 2008-08-01 14:08

Message:
Logged In: YES 
user_id=1212856
Originator: NO

I had the same issue, fixed it by setting the acc flag again in the
failure route. Not expected behaviour though, so I would qualify it as a
bug.

----------------------------------------------------------------------

Comment By: Daniel-Constantin Mierla (miconda)
Date: 2008-08-01 12:47

Message:
Logged In: YES 
user_id=1246013
Originator: NO

Let's first understand if this is a bug at some point or a feature
request.

Do you say that even the call is answered you don't see the INVITE in the
acc table, but just the BYE? If so, can be a bug, but this would have been
reported many times as it is a common situation for a SIP call and the
accounting record is important. Check if you don't reset the acc flag in
some failure route.

On another hand, if you want to get all failed branches logged in
missed_calls, then looks like a feature request.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1979305&group_id=139143