[Kamailio-Devel] [ openser-Bugs-2026681 ] presence module does not send correct watcher info documents

[SourceForge.net]

Bugs item #2026681, was opened at 2008-07-24 11:24
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2026681&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Lucian Stanescu (luci_stanescu)
Assigned to: Nobody/Anonymous (nobody)
Summary: presence module does not send correct watcher info documents

Initial Comment:
Hello,

The attached patch corrects the following problems related to the watcher info implementation in the presence module:

1. At each subscribe within a dialog, the module sends a full watcherinfo document, always with version 0. There is no need to send a full watcherinfo document when a subscription is refreshed, but rather when the state of a watcher changes. The version number should be incremented within a dialog, not reset each time the subscription is refreshed.

2. When the state of a watcher changes, it sends a watcherinfo document with only that watcher's status, but with a state attribute set to "full". The state attribute should be "partial".

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2008-08-06 15:09

Message:
Logged In: NO 

> There is no need to send a full watcherinfo document when 
> a subscription is refreshed, but rather when the state of 
> a watcher changes. 

Can you point me to the definition of this? I only found in RFC 3265:

3.1.6.2. Confirmation of Subscription Creation/Refreshing

   Upon successfully accepting or refreshing a subscription, notifiers
   MUST send a NOTIFY message immediately to communicate the current
   resource state to the subscriber.  This NOTIFY message is sent on the
   same dialog as created by the SUBSCRIBE response.  If the resource
   has no meaningful state at the time that the SUBSCRIBE message is
   processed, this NOTIFY message MAY contain an empty or neutral body.
   See section 3.2.2. for further details on NOTIFY message generation.

But in our case there IS a meaningful state.

> The version number should be incremented within a dialog, not reset 
> each time the subscription is refreshed.

This claim is correct

> When the state of a watcher changes, it sends a watcherinfo document
> with only that watcher's status, but with a state attribute set to
"full".
> The state attribute should be "partial".

This claim is correct too.

I just saw there was a fix in rev4547, but commit log says: version fixed,
but the patch did not fixed the version thing, but the "partial" thing

klaus

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2026681&group_id=139143