[OpenSER-Devel] TEXT vs BLOB data in database modules

[Daniel-Constantin Mierla]

Hello Henning,

On 04/21/08 11:44, Henning Westerholt wrote:
> On Saturday 19 April 2008, Daniel-Constantin Mierla wrote:
>   
>> for DB_STRING it has to be checked if all drivers return a null
>> terminated string, as some just set reference to the value in the
>> library result and not clone the value.
>>
>> Otherwise, I would say that the most suitable type in DB api right now
>> is DB_STR. DB_BLOB is fine as well, mapping over str structure, just a
>> bit misleading for the potential new developers :-)
>>     
>
> Hi Daniel,
>
> do you suggest a conversion of all DB_STRING usage in the drivers to DB_STR?
Not really. I wanted to point out that if the decision is to go for 
DB_STRING, a check of all db driver must be undertaken to make sure the 
returned value by the underlying library for these column types is 
zero-terminated (as most of the drivers do not clone the value in 
db_res, just link to the pointer).

And I expressed that, from my point of view, such columns (long text 
values) fit the best over the DB_STR type -- DB_BLOB is clear suggesting 
binary data and it is not the case here.

Cheers,
Daniel

>  I 
> think this is another issue, appart from the DB_BLOB problems i'm trying to 
> address now. At the moment db_mysql and db_postgres only returns DB_STRING.
>
> Cheers,
>
> Henning
>   

-- 
http://www.asipto.com