[OpenSER-Devel] [ openser-Bugs-1932221 ] dialog: improper in dialog request direction detection

[SourceForge.net]

Bugs item #1932221, was opened at 2008-04-02 16:15
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1932221&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Ovidiu Sas (osas)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: dialog: improper in dialog request direction detection

Initial Comment:
For in dialog request, the direction of the request is not properly detected.  The attached patch fixes the issue.

Regards,
Ovidiu Sas

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-04-18 13:13

Message:
Logged In: YES 
user_id=1275325
Originator: NO

OK - testing done and also backported to 1.3 .

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-04-10 20:04

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Ovidiu,

The patch is on SVN - I will run a bit more tests before doing a backport
on 1.3

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2008-04-04 17:35

Message:
Logged In: YES 
user_id=1395524
Originator: YES

Hello Bogdan,

Following the terminology that you proposed, here's the attached patch.
I left in the debug probes that I used in order to debug the direction
(those probes will need to be removed).


Regards,
Ovidiu Sas
File Added: dlg_dir_detection.patch

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-04-04 12:39

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Ovidiu,

First just to agree on terminology.
- initial request has a DOWNSTREAM direction
- within the dialog requests from original caller to original callee ->
DOWNSTREAM
- within the dialog requests from original callee to original caller ->
UPSTREAM

Let me know if according to this definitions, the issues is still
present.

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1932221&group_id=139143