[OpenSER-Devel] [ openser-Bugs-1932404 ] append_branch should push path-vector into branch

[SourceForge.net]

Bugs item #1932404, was opened at 2008-04-02 15:41
Message generated for change (Comment added) made by carstenbock
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1932404&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: ver 1.3.x
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Carsten Bock (carstenbock)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: append_branch should push path-vector into branch

Initial Comment:
Hi,

is there any reason, why append_branch(called from the config) will not push the path-vector (msg->path_vec) into the branch?
I have the following scenario:

$rU = "alice";
lookup();
# Path vector is filled with info for alice
append_branch();
$rU = "bob";
lookup();
# Path vector is filled with info for bob
t_relay();

In this case, only the path-information for bob is used and the path information for alice is ignored.

Attached patch will push the path-information into the branch.

Carsten




----------------------------------------------------------------------

>Comment By: Carsten Bock (carstenbock)
Date: 2008-04-04 10:12

Message:
Logged In: YES 
user_id=1488991
Originator: YES

Hi Bogdan,

Currently, i think this is only done by the registrar module...
If looked into the source of "modules/registrar/lookup.c" and identified
the following: The first lookup fills "msg->path_vec" with the
path-information; in case of additional branches/forking the path
information is given as the parameter of from "append_branch()" of
"dset.h".
In the action.c, the "path" parameter for "append_branch()" is set to "0".
I've changed the code to use the "msg->path_vec" in this case; and like the
"msg->dst_uri" is cleared after "append_branch()" in "action.c", i've also
cleared the "msg->path_vec".

Carsten

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-04-04 09:43

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Carsten,

How do you push the path info into the msg? afaik, only usrloc module does
this, right?

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1932404&group_id=139143