[OpenSER-Devel] [ openser-Patches-1660596 ] query logging in mysql module

[SourceForge.net]

Patches item #1660596, was opened at 2007-02-15 13:19
Message generated for change (Comment added) made by henningw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1660596&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
>Status: Closed
Resolution: None
Priority: 5
Private: No
Submitted By: Henning Westerholt (henningw)
>Assigned to: Henning Westerholt (henningw)
Summary: query logging in mysql module

Initial Comment:
Hi,

the attached patch adds query logging to the mysql module. This is configurable through a exported variable. We're using this for debugging purposes. 

Please apply,

Henning

----------------------------------------------------------------------

>Comment By: Henning Westerholt (henningw)
Date: 2007-09-27 07:59

Message:
Logged In: YES 
user_id=337916
Originator: YES

Could be also achieved with mysql logging.

Close the patch.

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-02-21 20:10

Message:
Logged In: YES 
user_id=1275325
Originator: NO

yes, this is a solution, but isn't it a bit too "costly" just for logging
purposes? isn't more suitable to use the logs from mysql server? just
asking. If somebody wants to write this function (which can be turned off),
I personally have nothing against it.

regards,
bogdan

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2007-02-21 09:15

Message:
Logged In: YES 
user_id=337916
Originator: YES

Hi,

a possible solution to this problem is to copy the query string, 
check the output with the function iscntrl and suppress or escape
the control characters. After that you can safely output the string.

If this a feasible solution i would extend the patch.



----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-02-19 15:18

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Henning,

Logging of the mysql queries was present in openser as permanent debug
log, but was removed as there are modules working with BLOBS (cpl-c) which
contains non-printable caracters - this was screwing up the terminal
:(....
I would say we need to find a solution to prevent this before enabling
this feature...

Thanks and regards,
bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1660596&group_id=139143