[OpenSER-Devel] [ openser-Patches-1634424 ] Patch to fix warnings when compiling and some possible bugs

[SourceForge.net]

Patches item #1634424, was opened at 2007-01-12 22:52
Message generated for change (Comment added) made by henningw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1634424&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: ver devel
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: egable (egable1)
Assigned to: Bogdan (bogdan_iancu)
Summary: Patch to fix warnings when compiling and some possible bugs

Initial Comment:
This patch enables -W -Wall on compiling instead of -Wall only. It also fixes many signedness warnings, several possible bugs, and offers better 64-bit compatability.

----------------------------------------------------------------------

>Comment By: Henning Westerholt (henningw)
Date: 2007-09-27 07:52

Message:
Logged In: YES 
user_id=337916
Originator: NO

The current trunk uses -Wall -Wold-style-definition
-Wmissing-field-initializers,
but "-W" is still to noisy with the actual codebase.

Cheers,

Henning

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-03-09 13:19

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Eliot,

I'm reviewing your patch and part of it is already applied! thanks.

Just several questions.

I haven't added -W as it genrates to much warnings and there is too late
to fix all of them now, days before release, and especially that there are
no real warnings, but most of them about conformity. 
For example, the unsused param warning - you solved it via "__attribute__
((unused))", but is this C99 and ANSIC compliant? do other compilers accept
it (like suncc)? As an alternative, I compiled with -Wno-unused-parameter,
but this gcc option is not present in all older versions.

about casting all "int" related to diff of pointers to "size_t", it is
logicaly corect, but not necessary as openser does not process chunks of
date so large to need a 64bits data to keep the offset.

regards,
bogdan

----------------------------------------------------------------------

Comment By: egable (egable1)
Date: 2007-01-15 18:07

Message:
Logged In: YES 
user_id=1690723
Originator: YES

This new patch also fixes all "unused parameter" warnings throughout the
code base. 
File Added: fix-all-warnings.zip

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1634424&group_id=139143