[OpenSER-Devel] [ openser-Bugs-1821002 ] [pua_usrloc] ERROR: PUBLISH with empty body

Mon Oct 29 12:29:39 UTC 2007

Bugs item #1821002, was opened at 2007-10-26 22:59
Message generated for change (Comment added) made by anca_vamanu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1821002&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
Status: Closed
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Iñaki Baz (ibc_sf)
Assigned to: anca (anca_vamanu)
Summary: [pua_usrloc] ERROR: PUBLISH with empty body

Initial Comment:
SVN 2983 revision.

Sometimes (not sure when exactly) pua_usrloc generates a PUBLISH with empty body and an error:

 ERROR:pua:send_publish: New PUBLISH and no body 
    found- invalid request
 ERROR:pua_usrloc:ul_publish: while sending publish

This is a pua_usrloc generated PUBLISH with error reply and NOTIFY (as example):

U 2007/10/27 00:53:16.734278 85.67.0.110:5060 -> 85.67.0.110:5060
PUBLISH sip:ibc at sip.domain.net SIP/2.0
Via: SIP/2.0/UDP 85.67.0.110;branch=z9hG4bK0ef1.16d6a215.0
To: sip:ibc at sip.domain.net
From: sip:ibc at sip.domain.net;tag=533cb9e91f4b999cf76861cbb9ed54ed-1e36
CSeq: 10 PUBLISH
Call-ID: 3feff7e3-9115 at 127.0.0.1
Content-Length: 0
User-Agent: OpenSER (1.3.0-pre1-tls (i386/linux))
Event: presence
Expires: 0
SIP-If-Match: a.1193437958.9100.1.1

#
U 2007/10/27 00:53:16.735156 85.67.0.110:5060 -> 85.67.0.110:5060
SIP/2.0 412 Conditional request failed
Via: SIP/2.0/UDP 85.67.0.110;branch=z9hG4bK0ef1.16d6a215.0;rport=5060
To: sip:ibc at sip.domain.net;tag=329cfeaa6ded039da25ff8cbb8668bd2.1ac8
From: sip:ibc at sip.domain.net;tag=533cb9e91f4b999cf76861cbb9ed54ed-1e36
CSeq: 10 PUBLISH
Call-ID: 3feff7e3-9115 at 127.0.0.1
Server: OpenSER (1.3.0-pre1-tls (i386/linux))
Content-Length: 0

#
U 2007/10/27 00:53:16.735217 85.67.0.110:5060 -> 62.57.20.167:5080
NOTIFY sip:ibc_sip_domain_net at 62.57.20.167:5080 SIP/2.0
Via: SIP/2.0/UDP 85.67.0.110;branch=z9hG4bK5b09.a2ced663.0
To: sip:ibc at sip.domain.net;tag=bdzoz
From: sip:ibc at sip.domain.net;tag=10.3832.1193437933.4
CSeq: 7 NOTIFY
Call-ID: bxwqzghpdzloyaj at 62.57.20.167
Content-Length: 0
User-Agent: OpenSER (1.3.0-pre1-tls (i386/linux))
Max-Forwards: 70
Event: presence
Contact: <sip:85.67.0.110>
Subscription-State: active;expires=258
Content-Type: application/pidf+xml

I think this never ocurred with same configuration in OpenSer 1.2.2.

----------------------------------------------------------------------

>Comment By: anca (anca_vamanu)
Date: 2007-10-29 12:29

Message:
Logged In: YES 
user_id=1614776
Originator: NO

The module sends a Publish with a body only when the initial Register
arrives- it has basic status open. The next Publish messages for expire
update - triggered by re-Register messages- and the final one when the
client unRegisters(where Expires: 0) do not contain a body, as they
represent an update for Expires and not the state previously published.
Before the commit you mentioned, the update Publish alsp had a body, with
the same state - open. But since there is no need for that, it was changed,
improving this way the processing time.

regards, 
Anca

----------------------------------------------------------------------

Comment By: Iñaki Baz (ibc_sf)
Date: 2007-10-29 12:11

Message:
Logged In: YES 
user_id=1844020
Originator: YES

Thanks.
Could you explain a little what does the module do now? does it send an
empty PUBLISH if the user is already registered? or in which case does it
send an empty PUBLISH?

Thanks for any explanation.

----------------------------------------------------------------------

Comment By: anca (anca_vamanu)
Date: 2007-10-29 11:48

Message:
Logged In: YES 
user_id=1614776
Originator: NO

Hello,

The bug was, in fact, introduced earlier, with the changes made for rls
module. It is now fixed.
Thanks for reporting.

regards, 
Anca Vamanu 

----------------------------------------------------------------------

Comment By: Iñaki Baz (ibc_sf)
Date: 2007-10-27 18:04

Message:
Logged In: YES 
user_id=1844020
Originator: YES

Ok, I'm trying and this issue (PUBLISH with empty body) occurs when the
UAC sends a REGISTER and it was already registered.

And I think this is because a commit based in this mail thread:
  http://lists.openser.org/pipermail/users/2007-October/013652.html
  "After reading the thread, I also came to your conclusion, that by 
   sending Publish with no bodies for refresh the problem should be
solved- 
   thus I made the commit. "  --Anca Vamanu

But the fact is that an error occurs:

  Oct 27 20:00:44 [21345] ERROR:pua:send_publish: New PUBLISH and no body
found- invalid request
  Oct 27 20:00:44 [21345] ERROR:pua_usrloc:ul_publish: while sending
publish

and there is not a generated PUBLISH so "presentity" tabla is not updated.

----------------------------------------------------------------------

Comment By: Iñaki Baz (ibc_sf)
Date: 2007-10-26 23:01

Message:
Logged In: YES 
user_id=1844020
Originator: YES

I'd like to report more complete data, but not sure when this issue
occurs.
Please, ask for every thing I could try to find the issue.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1821002&group_id=139143