[OpenSER-Devel] [ openser-Bugs-1813052 ] fix syntax error in uac_auth qop support

[SourceForge.net]

Bugs item #1813052, was opened at 2007-10-14 02:52
Message generated for change (Comment added) made by aheise
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1813052&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Andreas Heise (aheise)
Assigned to: Bogdan (bogdan_iancu)
Summary: fix syntax error in uac_auth qop support

Initial Comment:

The values of the fields "qop", "nc" and "algorithm" in the AUTHORIZATION_HDR / PROXY_AUTHORIZATION_HDR must be unquoted (single token) instad of quoted-string.

Due to this syntax error uac_auth was not successfull with my carrier.

For details see the example in chapter 22.2 of RFC 3261 

Attached is a patch to fix this issue 


----------------------------------------------------------------------

>Comment By: Andreas Heise (aheise)
Date: 2007-10-22 12:54

Message:
Logged In: YES 
user_id=1685683
Originator: YES

Test with SVN devel REV 2966 successful..

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-10-20 19:36

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Andreas,

I applied the patch - please test again with the SVN devel version. If
everything ok I will do the backport to 1.2

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Andreas Heise (aheise)
Date: 2007-10-16 09:34

Message:
Logged In: YES 
user_id=1685683
Originator: YES

Hi Bogdan,

OK, for the case that the fix is needed and this seems to be.
I've add a simplifyed version of the patch to keep the code 
more clean and simple.

regards,
Andreas

 
File Added: unquoted_qop_nc_algo2.patch

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-10-15 20:04

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Andreas,

This looks more like a potential BUG to me, so I moved it accordingly. I
will take a look at the SIP specs to double check and see if something
needs to be fixed.

Thanks and regards,
Bogdan

----------------------------------------------------------------------

Comment By: Andreas Heise (aheise)
Date: 2007-10-15 13:58

Message:
Logged In: YES 
user_id=1685683
Originator: YES

patch is OK, it was just a confusion ;-), ready to commit?!
File Added: unquoted_qop_nc_algorithm.patch

----------------------------------------------------------------------

Comment By: Andreas Heise (aheise)
Date: 2007-10-15 12:44

Message:
Logged In: YES 
user_id=1685683
Originator: YES

during tests I found an issue with wrong buffer calculation in very
specific case, I'll check this and provide new a patch after...

----------------------------------------------------------------------

Comment By: Andreas Heise (aheise)
Date: 2007-10-14 20:53

Message:
Logged In: YES 
user_id=1685683
Originator: YES

File Added: unquoted_qop_nc_algorithm.patch

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1813052&group_id=139143