[OpenSER-Devel] SF.net SVN: openser: [3156] trunk/modules/permissions/mi.c

[Henning Westerholt]

On Tuesday 20 November 2007, Bogdan-Andrei Iancu wrote:
> > this is exactly the type of interface that makes programming and
> > debugging in OpenSER for me more hard than necessary. I could tell you a
> > story from a recent bug caused of the non-type safty of the str_init
> > macro, or explain my understanding of "good" API design, but as you said,
> > lets try to don't get religious about this issues. I really like the good
> > performance of the server, but i don't see a compelling need for high
> > performance FIFO commands.

Hi Bogdan,

> nobody said programming is easy :d, but in my opinion the software we
> are doing has as main purpose to do a job as best possible and not to be
> an example of structured code, APIs or easy to work with - all these
> come on the second step.

well, if our production systems dies periodically without any apparent reason and causes QoS problems, the ability to work easy and debug efficient in the code is - at this moment - the most important thing for me. If i need hours to get some small work done with the available API, then there is obviously some room for improvement - both for my OpenSER skills ;-) and the structure and documentation of the code. This issues are faced even more by new people coming to this project. 

I do not want to sacrifice performance without a need, but i have a more balanced view of this points. So i guess we'll need to find some compromises here (as we've in the past), as OpenSER will stay an important piece of the VoIP infrastructure here.

> [..]
> anyhow, it is not only about FIFO, but for all MI and later this started
> to be more and more used. Secondly I'm not in favour to introduce any
> kind of penalty if can be avoided.
>
> > Anyway, i want to second the objections that Dan raised in his mails. I
> > see a need to discuss this change more thoroughly, as this is the type of
> > interfaces that i don't like to see that much in new code.
>
> The interface was not changed - it was inserted an helper macro to
> minimize as much as possible the probability to insert a bug due bogus
> length.

Ok. This is your point of view. :-) But lets not start a fight about few lines change.

> [..]
> > We're releasing 1.3 in about two weeks, and then we can all start hacking
> > again, i'm counting the days too.. ;-)
>
> yes, but till then the priority 1 is to have a code as safer as possible
> and as bug-free as possible. This is my major concern for the moment,

And for me too.

Cheers,

Henning
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.openser.org/pipermail/devel/attachments/20071121/8168578d/attachment.htm