[OpenSER-Devel] SF.net SVN: openser: [3156] trunk/modules/permissions/mi.c

[Henning Westerholt]

On Monday 19 November 2007, Bogdan-Andrei Iancu wrote:
> To solve this potential problem without any change in the MI interface
> and without no runtime penalties (strlen), I just added a small macro
> MI_SSTR (MI  Static String) to compute the len of a static string at
> compile time.
>
> With it, instead of having:
>     add_mi_node_child( rpl, 0, "Server", 6,......
> you can do:
>     add_mi_node_child( rpl, 0, MI_SSTR("Server"),.....
>
> As a POC, I did the changes on the MI core functions and the permission
> module.

Bogdan,

this is exactly the type of interface that makes programming and debugging in 
OpenSER for me more hard than necessary. I could tell you a story from a 
recent bug caused of the non-type safty of the str_init macro, or explain my 
understanding of "good" API design, but as you said, lets try to don't get 
religious about this issues. I really like the good performance of the 
server, but i don't see a compelling need for high performance FIFO commands.

Anyway, i want to second the objections that Dan raised in his mails. I see a 
need to discuss this change more thoroughly, as this is the type of interfaces 
that i don't like to see that much in new code.

I don't want to waste my and your time now to discuss this issues, and i also 
think we're currently to late in the release cycle for an introduction of a 
new interface to the core. So i would like to ask you to revert the addition 
of the new macro and the changes in the mi core and permission module.

We're releasing 1.3 in about two weeks, and then we can all start hacking 
again, i'm counting the days too.. ;-)

Thank you and best regards,

Henning