[OpenSER-Devel] [ openser-Feature Requests-1689663 ] dispatcher does not modify URI parameters

[SourceForge.net]

Feature Requests item #1689663, was opened at 2007-03-28 09:59
Message generated for change (Comment added) made by miconda
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743023&aid=1689663&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: modules
>Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Klaus Darilion (klaus_darilion)
Assigned to: Daniel-Constantin Mierla (miconda)
Summary: dispatcher does not modify URI parameters

Initial Comment:
Hi!

There is a problem with dispatcher module. The ds_select_domain() function does only change the host:port part of the RURI, but leaves existing RURI parameters untouched.

Consider the following scenario. A calls B. (B has REGISTERed vi TCP).

after lookup() the RURI is sip:B at 1.2.3.4;transport=tcp

If this call fails, and the call is forwarded to the PSTN in failure route using ds_select_domain(), the new RURI still contains the transport=tcp parameter.

IMO the transport parameters should be changed when using ds_select_domain().

I found this behaviour with openser 1.1 but I think it is identical with 1.2

----------------------------------------------------------------------

>Comment By: Daniel-Constantin Mierla (miconda)
Date: 2007-11-16 18:14

Message:
Logged In: YES 
user_id=1246013
Originator: NO

If one wants to remove the parameters now, can do:

$ru = "sip:" + $rU + "@" + $rd

Since the functions of dispatcher have specific behavior, underlined by
name as well, I move this as a feature request. The current functions in
dispatcher do what they are supposed to do for now: set dst uri, or domain
part of r-uri.

----------------------------------------------------------------------

Comment By: Klaus Darilion (klaus_darilion)
Date: 2007-04-18 12:11

Message:
Logged In: YES 
user_id=1318360
Originator: YES

What about a function ds_select_domainparams which overwrites
host:port;params ?

----------------------------------------------------------------------

Comment By: Daniel-Constantin Mierla (miconda)
Date: 2007-04-04 16:55

Message:
Logged In: YES 
user_id=1246013
Originator: NO

It is a bit delicate. I was considering the case when the parameters can
be something meaningful. In case of transport could be considered bug,
otherwise, the parameters should be kept.

One solution would be to make it configurable somehow.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743023&aid=1689663&group_id=139143