[OpenSER-Devel] SF.net SVN: openser: [3156] trunk/modules/permissions/mi.c
Henning Westerholt
henning.westerholt at 1und1.de
Fri Nov 16 13:09:50 UTC 2007
On Friday 16 November 2007, Dan Pascu wrote:
> Revision: 3156
> http://openser.svn.sourceforge.net/openser/?rev=3156&view=rev
> Author: dan_pascu
> Date: 2007-11-16 04:45:39 -0800 (Fri, 16 Nov 2007)
>
> Log Message:
> -----------
> Fixed length of string constants. This should be better done by #define-ing
> some constants and using sizeof(constant)-1 on them.
Hi Dan,
even better would be to let mi_init_tree calculate the string length, and
avoid this manual and error-prone initialization. The small runtime overhead
is negligible, as the fifo commands are not performance critical.
Just an idea - best regards,
Henning
More information about the Devel
mailing list