[OpenSER-Devel] [ openser-Bugs-1831969 ] parse_methods should ignore invalid/unknown methods

[SourceForge.net]

Bugs item #1831969, was opened at 2007-11-14 13:52
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1831969&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ovidiu Sas (osas)
Assigned to: Nobody/Anonymous (nobody)
Summary: parse_methods should ignore invalid/unknown methods

Initial Comment:
I was doing some testing with a phone that is sending the "SERVICE" method inside the Allow header.
When the header is parsed, because the "SERVICE" method is not known, the parser just aborts and all the already parsed headers are lost.

It would be nice to skip the unknown headers and keep all the known headers (see the registration case, when the allowed methods are stored in usrloc).

Attached is a patch that will ignore unknown headers.

It will print a warning log like this:
Nov 14 14:08:14 localhost /usr/local/sbin/openser[8922]: core:parse_methods: ignoring invalid method:SERVICE,UPDATE,PRACK 


Regards,
Ovidiu Sas

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1831969&group_id=139143