[OpenSER-Devel] [ openser-Bugs-1803916 ] DNS resolve error handeling doesn't triger failure_route

[SourceForge.net]

Bugs item #1803916, was opened at 2007-09-28 03:09
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1803916&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
>Group: ver devel
>Status: Closed
>Resolution: Invalid
Priority: 5
Private: No
Submitted By: serwide (daveswide)
Assigned to: Bogdan (bogdan_iancu)
Summary: DNS resolve error handeling doesn't triger failure_route

Initial Comment:
Using OpenSER 1.2.1
When I have a FQDN in my R-URI and DNS is not available or the FQDN doesn't resolve, the error logs show:
ERROR: mk_proxy: could not resolve hostname: "srv.dest.sipserver.com"
ERROR: uri2proxy: bad host name in URI <sip:mynum at srv.dest.sipserver.com>
ERROR:tm:t_forward_nonack: failure to add branches

for sending the call I have
t_on_failure("1");
if (!t_relay()) {
  # This section doesn't seem to be reached even on failures.
  xlog("L_INFO", "Failed sending to: $ru\n");
}
exit;

but even through I have t_on_failure(1); prior to t_route(), failure_route[1] is never hit. failuer_route[1] is hit/used if FQDN does resolve and sip call fails/rejected.

I also have a error function that has never been hit:
error_route { 
  xlog("L_INFO", "--- error route class=$(err.class)...."); 
}


----------------------------------------------------------------------

>Comment By: Bogdan (bogdan_iancu)
Date: 2007-11-14 10:40

Message:
Logged In: YES 
user_id=1275325
Originator: NO

The failure route is triggered only where is a failure at SIP level
(negative reply received). A failure of sending out the request will not
trigger failure route, but it will reported in script by t_relay (depensing
of what flag are set).

So the failure of resolving the destination via DNS will not trigger
failure route.

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: serwide (daveswide)
Date: 2007-11-13 21:54

Message:
Logged In: YES 
user_id=1900568
Originator: YES

Yes, maybe.
I had missed the t_relay("0x02") flag.
failure_route[1] was working when I was just using IP addresses with out
setting the 0x02 flag
I had assumed that failures would be handled the same way and therefore
did not go looking for flags/parameters.

So as I understand it, if I send out the call with t_relay("0x02")
  * auto failover acording to DNS SRV records when sip communication to
one of the srv resolved servers, fails will still work and will not trigger
failure_route.
  * failure/error messages from destination sip server will trigger
failure_route (assuming t_on_failure is set).
  * DNS resolution failure/error will trigger failure_route (assuming
t_on_failure is set).

Thanks!
Dave

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-11-13 10:56

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Normally an automatica err reply is sent back to the client. If you want
to disable this reply and deal with the error from the script, there is a
parameter for t_relay() :
   http://www.openser.org/docs/modules/1.2.x/tm.html#AEN335
See flag 0x02.

Is this what you are looking for?

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: serwide (daveswide)
Date: 2007-11-13 03:54

Message:
Logged In: YES 
user_id=1900568
Originator: YES

I didn't check in packet capture for error reply to originating caller. 
My guess is that it did send an error reply.
However the problem is that I can not handle the dns lookup failure
gracefully in openser by sending it down other gateways, or ultimately
sending them to a media server to play the appropriate message about the
error.

Thanks,
Dave

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-11-12 16:20

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi,

Don't you see on an error reply automatically generated by openser in this
case? (even if it is not controlable from script).

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1803916&group_id=139143