[OpenSER-Devel] [ openser-Bugs-1752168 ] lcr does not work with dbtext

[SourceForge.net]

Bugs item #1752168, was opened at 2007-07-11 22:28
Message generated for change (Comment added) made by miconda
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1752168&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.2.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Andreas Granig (agranig)
>Assigned to: Daniel-Constantin Mierla (miconda)
Summary: lcr does not work with dbtext

Initial Comment:
Hi,

LCR module checks for DB_STRING type of the gw_addr column in the gw table, but the dbtext backend returns DB_STR. Attached you can find a quick fix for 1.2.x. (I guess HEAD branch has this problem too). Please review, improve and apply.

Andreas

----------------------------------------------------------------------

>Comment By: Daniel-Constantin Mierla (miconda)
Date: 2007-11-09 17:36

Message:
Logged In: YES 
user_id=1246013
Originator: NO

Should be fixed with the last set of commits in dbtext. It supports
DB_STRING and when inserting, it checks for compatibility of column types,
instead of equality.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-07-14 15:40

Message:
Logged In: NO 

what happened between 1.1 and 1.2 was that in 1.1 ip address was stored in
db as unsigned int and in 1.2 as a string.  this explains why the
string/str problem didn't appear in 1.1.

as i said earlier, this is not an lcr specific problem and should be
addresses in dbtext backend.

----------------------------------------------------------------------

Comment By: Andreas Granig (agranig)
Date: 2007-07-14 15:24

Message:
Logged In: YES 
user_id=825350
Originator: YES

I basically agree that the better solution is to change dbtext, but in
this case something in LCR changed between 1.1.x and 1.2.x which made it
break in combination with dbtext. So for me it's perfectly valid to work
around this dbtext limitation so 1.2.x can be used in this scenario, until
dbtext is enhanced to also return STRING.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-07-14 12:43

Message:
Logged In: NO 

your patch makes lcr module to accept both STRING and STR results for ip
address, because as you say dbtext returns str rather than string result. 
in my opinion better solution would be to make dbtext module return string
result, because then the code would not need to be duplicated in each
module that uses string database values.

-- juha

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1752168&group_id=139143