[OpenSER-Devel] SF.net SVN: openser: [3064] trunk/scripts/openserdbctl.base

[Dan Pascu]

On Friday 09 November 2007, Henning Westerholt wrote:
> On Thursday 08 November 2007, Dan Pascu wrote:
> > On Thursday 08 November 2007, Henning Westerholt wrote:
> > > Revision: 3064
> > >          
> > > http://openser.svn.sourceforge.net/openser/?rev=3064&view=rev
> > > Author:   henningw
> > > Date:     2007-11-08 07:55:52 -0800 (Thu, 08 Nov 2007)
> > >
> > > Log Message:
> > > -----------
> > > - fix the bug in the script that makes it impossible to override
> > > the 'ask' setting in the openserctlrc file
> >
> > What exactly do you mean by bug here? That construct is the bash
> > syntax to specify that if the variable is not defined then use the
> > default value, the one that comes after :-
> > That construct was used exactly to avoid having to test if the
> > variable is defined or not before assigning the default value.
>
> Hello Dan,
>
> strange, on my tests this don't seems to work.. But i've tested it
> again, and now its ok. So this commit was wrong.
>
> Do you think that it make sense to replace all these 'if' cases there
> with that construct you've added?

openserctl & openserdbctl already use /bin/bash so this is why I preferred 
to use them. They're much cleaner and simpler and I favor them over the 
if construct. Since we use /bin/bash I see no reason not to use them.


-- 
Dan