[OpenSER-Devel] [ openser-Bugs-1828425 ] siptrace double logs the incoming replies

[SourceForge.net]

Bugs item #1828425, was opened at 2007-11-08 19:58
Message generated for change (Comment added) made by miconda
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1828425&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
>Status: Closed
>Resolution: Invalid
Priority: 5
Private: No
Submitted By: Dan (dan_pascu)
>Assigned to: Daniel-Constantin Mierla (miconda)
Summary: siptrace double logs the incoming replies

Initial Comment:
Every incoming reply is saved twice in the database. The only difference I've seen between the 2 entries is that one has the method field set to the method for which the reply was send, while the other has the method field empty.

Here is an excerpt from the entries generated by a call:

| INVITE | 183    | udp:p1:5060  | udp:p2:5060  | in   |
|        | 183    | udp:p1:5060  | udp:p2:5060  | in   |
| INVITE | 183    | udp:p2:5060  | udp:p3:5060  | out  |
| INVITE | 183    | udp:p2:5060  | udp:p3:5060  | in   |
|        | 183    | udp:p2:5060  | udp:p3:5060  | in   |
| INVITE | 183    | udp:p3:5060  | udp:tel:5062 | out  |

The network traffic dump shows the packet was only sent once. From the excerpt above it can be seen that the outgoing packet is only logged once (correct), but it then appears twice on the next proxy's incoming log.

The configuration I use is pretty simple and it the same I have used with 1.1.x and it worked there. I call sip_trace() and set the trace flag for every incoming method I want to trace and then I call sip_trace in every reply route corresponding to the requests I have traced.

----------------------------------------------------------------------

>Comment By: Daniel-Constantin Mierla (miconda)
Date: 2007-11-08 20:30

Message:
Logged In: YES 
user_id=1246013
Originator: NO

In the reply routes you do not need to call sip_trace if you have set the
appropriate flag. The flag marks the transaction to sip-trace any reply
that is sent within it, for in and out events. In this case, it is saved
once due to flag set, and second because of sip_trace in reply route. If I
am not wrong, the storage in case of 'in' within a transaction was added
after 1.2, before the flag marked only for 'out' cases.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1828425&group_id=139143