[Devel] [ openser-Bugs-1723492 ] Incorect behaviour of swap flag for rtpproxy

[SourceForge.net]

Bugs item #1723492, was opened at 2007-05-22 10:04
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1723492&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.2.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ovidiu Sas (osas)
Assigned to: Nobody/Anonymous (nobody)
Summary: Incorect behaviour of swap flag for rtpproxy

Initial Comment:
The swap 's' flag of force_rtp_proxy() from nathelper module should swap the tp/from tags just like the lookup 'l' flag does.

The following patch will fix the problem:

# diff -Naurp nathelper.c nathelper.c.new
--- nathelper.c	2007-05-22 09:58:27.000000000 -0400
+++ nathelper.c.new	2007-05-22 09:58:19.000000000 -0400
@@ -1864,6 +1869,13 @@ force_rtp_proxy2_f(struct sip_msg* msg, 
 		from_tag = to_tag;
 		to_tag = tmp;
 	}
+	if (swap != 0) {
+		if (flookup == 0) {
+			tmp = from_tag;
+			from_tag = to_tag;
+			to_tag = tmp;
+		}
+	}
 	proxied = 0;
 	if (nortpproxy_str.len) {
 		for ( cp=body.s ; (len=body.s+body.len-cp) >= nortpproxy_str.len ; ) {


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1723492&group_id=139143