[Devel] [ openser-Bugs-1694923 ] acc: failed_transaction_flag is ignored for db accounting

[SourceForge.net]

Bugs item #1694923, was opened at 2007-04-05 13:39
Message generated for change (Comment added) made by axlh
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1694923&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
Status: Closed
Resolution: Invalid
Priority: 5
Private: No
Submitted By: axlh (axlh)
Assigned to: Bogdan (bogdan_iancu)
Summary: acc: failed_transaction_flag is ignored for db accounting

Initial Comment:
It seems the 'failed_transaction_flag' setting is ignored by the database accounting. I see failed invite's in the syslog, but not in the db.
(Successfull calls are logged correctly)


relevant settings: (M4 macro's: FLAG_ACC=1, ACC="acc")

modparam("acc", "log_level", 3)
modparam("acc", "log_flag", FLAG_ACC)
modparam("acc", "db_flag", FLAG_ACC)
modparam("acc", "log_missed_flag", FLAG_ACC)
modparam("acc", "db_missed_flag", FLAG_ACC)
modparam("acc", "failed_transaction_flag", FLAG_ACC)

modparam("acc", "log_extra", "timestamp=$Ts")
modparam("acc", "db_extra", "timestamp=$Ts")

modparam("acc", "multi_leg_info", "src_leg_user=$avp(s:src_leg_user); src_leg_domain=$avp(s:src_leg_domain); dst_leg_user=$avp(s:dst_leg_user); dst_leg_domain=$avp(s:dst_leg_domain)")

modparam("acc", "db_table_acc", "ACC")
modparam("acc", "db_table_missed_calls", "ACC")

modparam("acc", "report_cancels", 0)
modparam("acc", "report_ack", 0)


----------------------------------------------------------------------

>Comment By: axlh (axlh)
Date: 2007-05-10 22:52

Message:
Logged In: YES 
user_id=1212856
Originator: YES

I still think this is a valid bug:

- documentation allows the use of the same flag.
- configuration check allows the use of the same flag.
- this used to work in 1.1.x
- it still works for log_flag and db_flag, just not for the missed
version.

I'll attach 2 patches which both seem to fix the issue. Please apply any
one if you agree with it.
File Added: fix-acc-missed-flag-1.patch

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-05-10 21:49

Message:
Logged In: YES 
user_id=1275325
Originator: NO

The reported behaviour is because of the usage of the same flag for
"db_missed_flag" and "log_missed_flag". The missed flags are reset after
the first usage, so sequential usage of multiple missed reports based on
the same flag will not works as after the first report, the flag will be
reseted and the following reports will be skipped.

regards,
bogdan

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-05-04 19:52

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi,

I would say the problem is that you are using the same flag for all of
options. Note that the missed_flag gets reseted at some point (after the
first triggering).

I run multiple tests and I was not able to reproduce your case.

regards,
bogdan

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-04-08 09:59

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi,

I will run some tests to see if I can reproduce it.

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: axlh (axlh)
Date: 2007-04-06 09:52

Message:
Logged In: YES 
user_id=1212856
Originator: YES

When I comment out the log_missed_flag line, the missed calls ARE logged
to the database. So it seems the syslog processing does something that
prevents subsequent database logging.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1694923&group_id=139143