[Devel] SF.net SVN: openser: [2180] trunk/modules/mi_xmlrpc

Bogdan-Andrei Iancu bogdan at voice-system.ro
Wed May 9 22:37:42 CEST 2007


Hi Juha,

thanks for the fix. I have two comments here:
    1) about the code - we can optimize to avoid passing twice the 
string (once in the hack function and once by strlen() ) - shouldn't be 
better for the hack function to return the len of the string and avoid 
the strlen?

    2) I think this fix should be also backported to 1.2

regards,
bogdan

Juha Heinanen wrote:
> Revision: 2180
>           http://openser.svn.sourceforge.net/openser/?rev=2180&view=rev
> Author:   juhe
> Date:     2007-05-09 10:16:04 -0700 (Wed, 09 May 2007)
>
> Log Message:
> -----------
> * Implemented hack that converts LFLF sequence in received XML-RPC
>   strings to CRLF sequence in order to overcome the "feature" of current
>   version of Abyss XML-RPC server that "normalizes" CRLF sequence to LF
>   character.
>
> Modified Paths:
> --------------
>     trunk/modules/mi_xmlrpc/README
>     trunk/modules/mi_xmlrpc/doc/mi_xmlrpc.sgml
>     trunk/modules/mi_xmlrpc/doc/mi_xmlrpc_user.sgml
>     trunk/modules/mi_xmlrpc/xr_parser.c
>
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
> _______________________________________________
> Devel mailing list
> Devel at openser.org
> http://openser.org/cgi-bin/mailman/listinfo/devel
>
>   




More information about the Devel mailing list