[Devel] Contribution to OpenSER

[Henning Westerholt]

On Tuesday 27 March 2007 18:33, Anatoly Pidruchny wrote:
> Dear OpenSER developers,
>
> we would like to contribute some changes to OpenSER that should be
> useful to all of the OpenSER community.

Hi Anatoly!

It is great to hear that you would like to contribute. 

> The first small but useful change that we want is the ability to run
> OpenSER in "no-daemon" mode. We need to do this to run OpenSER under
> daemontools. There is a -D option already that means "Do not fork into
> daemon mode". But the problem with this option is that it really means
> more then just "Do not fork into daemon mode". It really means do not
> fork at all, i.e. do not create any child OpenSER processes. The patch
> below adds a variable no_daemon in main.c, makes -D option only change
> the no_daemon variable and makes the variable no_daemon only control
> whether OpenSER daemonizes itself or not. Yes, this patch means that -D
> option will no longer change the value of dont_fork variable. Well, we
> think a new option has to be added that will turn on the dont_fork
> variable. This patch does not add such a new option.
>
> Please let me know what should I do contribute this patch. I can also
> add an additional option to control the dont_fork variable, if you
> suggest so. Below is the proposed patch.

In my opionion the normal behavior of "-D" should not be changed. This would 
only confuse users without so much gain. So the best would be to introduce a 
new variable that control only the daemonize behaviour.

If you have reworked your patch, you should add it to the patch tracker of the 
project, as Daniel said.

If you post another patch per e-mail (for review) it is the best to attach the 
file to the mail. If you include them in the mail, tabs and whitespaces get 
mixed up, and the patch need to reworked before it can be applied.

Cheers,

Henning