[Devel] Parse Errors, error_route and fixing common NAT ALG bugs

[Dan Pascu]

Klaus Darilion wrote:
>
>> Issue 2. The via header originally had a rport param from our client,
>> but the router stripped it off incorrectly, notice how it ends in just a
>> ; We believe this error is caused by Linksys WRT54G routers that don't
>> have recent firmware.
>> Via: SIP/2.0/UDP
>> 1.1.1.1:56261;branch=z9hG4bK-d87543-9b572d31e0515e44-1--d87543-;
>
> I have seen this many times too. The Via parser detects an error and 
> the message will be discarded before entering the routing script. IMO 
> it also makes sense to allow a ";" at the end - maybe turned on with a 
> parameter: "relaxed_via_checking=yes"
>
I disagree. Adding too many options for such trivial issues will only 
make things overly complex when it comes to configuring the proxy. A 
better approach is to use a policy of being strict in what you send and 
liberal in what you accept.

-- 
Dan