[Devel] SF.net SVN: openser: [1746] trunk

[vallimamod abdullah]

Hello Daniel,

On 3/6/07, Daniel-Constantin Mierla <daniel at voice-system.ro> wrote:
>
> Don't you have svnversion on a common path? I don't really get what you
> did, maybe showing the workaround will help to make work with default
> makefile.
>

Thank you for your quick reply.

My previous mail was not very clear in fact. The issue is not with
the path of svnversion but with  its arguments.  Here is the change
I have made in svnversion call:

--------------8<--------------
--- Makefile.defs.r1750 2007-03-06 14:38:33.872483252 +0100
+++ Makefile.defs.mine  2007-03-06 14:38:33.873482976 +0100
@@ -1,4 +1,4 @@
-# $Id: Makefile.defs 1756 2007-03-06 13:26:38Z miconda $
+# $Id: Makefile.defs 1746 2007-03-05 16:06:58Z miconda $
#
# makefile defs (CC, LD,a.s.o)
#
@@ -221,12 +221,7 @@
LEX  := $(shell echo "$${LEX}")
YACC := $(shell echo "$${YACC}")

-SVNREVISION=$(shell if [ -d .svn -a -f main.c ] ; then \
-                               if which svnversion 1>/dev/null; then \
-                                       $(INSTALL-TOUCH) main.c ;\
-                                       svnversion -n -c ;\
-                               fi ;\
-               fi )
+SVNREVISION=$(shell svnversion -n -c /home/vma/devel/openser)

# find compiler name & version
ifeq ($(CC),)
-------------->8--------------

I tested with the last change you have just made and it seems to
me that there is an infinite loop while invoking flex; I have nothing
after the following input:

vma at proxy-sip:~/devel/openser$ make
bison -d -b cfg cfg.y
cfg.y: conflicts: 1 shift/reduce
flex cfg.lex

But when I remove the "touch main.c" command, It works fine:

--------------8<--------------
Index: Makefile.defs
===================================================================
--- Makefile.defs       (revision 1756)
+++ Makefile.defs       (working copy)
@@ -228,7 +228,6 @@
 ifeq ($(SVNREVISION),)
 SVNREVISION=$(shell if [ -d .svn -a -f main.c -a -f Makefile.defs ] ; then \
                                if [ -x "$(SVNVERSION)" ] ; then \
-                                       $(INSTALL-TOUCH) main.c ;\
                                        $(SVNVERSION) -n -c . ;\
                                fi ;\
                fi )
-------------->8--------------

Hope this will help.

-- 
Regards,
-vma
.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: makefile-svnversion-ugly-hack.diff
Type: application/octet-stream
Size: 835 bytes
Desc: not available
Url : http://openser.org/pipermail/devel/attachments/20070306/ff7bd029/makefile-svnversion-ugly-hack-0001.obj