[Devel] [ openser-Bugs-1671435 ] dialog module $DLG_status

[SourceForge.net]

Bugs item #1671435, was opened at 2007-03-01 08:00
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1671435&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: modules
>Group: ver devel
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Andy Pyles (andy_pyles)
>Assigned to: Bogdan (bogdan_iancu)
Summary: dialog module $DLG_status

Initial Comment:
Note: filed this as a patch initially but should have filed as bug.

Currently, if a broken UA fails to mirror the 
Record-Route header
containing the cookie used for the dialog module, $DLG_status has an
undefined value. 

For example if you try and use the following logic, You will get a script parsing error.

if(($DLG_status<=3 || $DLG_status>=5) && method!="BYE") {
    xlog("L_INFO","BROKEN RECORD-ROUTE IMPLEMENTATION
    DLG_status=$DLG_status\n");
    exit;
}


A Patch is found below.


http://sourceforge.net/tracker/index.php?func=detail&aid=1669730&group_id=139143&atid=743022

----------------------------------------------------------------------

>Comment By: Bogdan (bogdan_iancu)
Date: 2007-03-02 17:35

Message:
Logged In: YES 
user_id=1275325
Originator: NO

I applied the patch you were refering at, but slightly different. If the
dialog was not found, NULL is returned, so you should try:
     if( $DLG_status==NULL && method!="BYE") {...}

regards,
bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1671435&group_id=139143