[Devel] [ openser-Patches-1731009 ] move print_* functions from db-modules to db core

[SourceForge.net]

Patches item #1731009, was opened at 2007-06-04 20:40
Message generated for change (Comment added) made by henningw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1731009&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Victor Gamov (vitspec)
Assigned to: Nobody/Anonymous (nobody)
Summary: move print_* functions from db-modules to db core

Initial Comment:
Hi!

When I prepare patch for MySQL PS I found that all DB modules (MySQL, UnixODBC, PostgreSQL) uses many similar functions like print_values() (I think its was created as copy-paste when new module writed).

I red devel list and found that Henning do many works to standardize such functions and move it into db/db_ut.c

In this patch I move print_values(), print_set() and print_where() functions into db/db_ut.c. New functions have db_ prefix in their names now.

MySQL and UnixODBC modules was patched to use new API. This modules are tested in simple environment (openser started, SELECT, INSERT, UPDATE works)

PostgreSQL module patched too but I haven't DB to test this patch.

Hope it will be usefull for OpenSER

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2007-06-11 14:02

Message:
Logged In: YES 
user_id=337916
Originator: NO

I've commited your patch after some small changes:

- fixing of a wrong define in the mysql val.h file
- removing of some superflous logging in db core (function pointer stuff)

I applied it to trunk, thanks again.

Henning

----------------------------------------------------------------------

Comment By: Victor Gamov (vitspec)
Date: 2007-06-05 21:10

Message:
Logged In: YES 
user_id=1625470
Originator: YES

Hi Henning!

If my comments or some improvments for this patch are needed please email
me

Thanks!

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2007-06-05 05:47

Message:
Logged In: YES 
user_id=337916
Originator: NO

Hello Victor,

thank you for the patch. This should be defininitly useful. I haven't
found time yet to look into this functions.

I'll review your patch in the next few days.

Cheers,

Henning

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1731009&group_id=139143