[Devel] [ openser-Bugs-1729833 ] Disabling DNS blacklisting causes segfault

[SourceForge.net]

Bugs item #1729833, was opened at 2007-06-02 10:32
Message generated for change (Comment added) made by agranig
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1729833&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.2.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Andreas Granig (agranig)
Assigned to: Bogdan (bogdan_iancu)
Summary: Disabling DNS blacklisting causes segfault

Initial Comment:
Disabling DNS blacklisting using t_relay("0x04") causes OpenSER to dump core, because t->uac[i].proxy in modules/tm/t_fwd.c:754 is NULL in that case.

The attached patch fixes this for me, please review and apply. Dev-trunk may be affected as well, but I haven't checked that.

----------------------------------------------------------------------

>Comment By: Andreas Granig (agranig)
Date: 2007-06-02 18:14

Message:
Logged In: YES 
user_id=825350
Originator: YES

Thanks, seems to be fixed now.

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-06-02 16:11

Message:
Logged In: YES 
user_id=1275325
Originator: NO

right...check please the new patch....

thanks
bogdan
File Added: blacklists.patch

----------------------------------------------------------------------

Comment By: Andreas Granig (agranig)
Date: 2007-06-02 12:38

Message:
Logged In: YES 
user_id=825350
Originator: YES

Bogdan,

There is still a NULL pointer accessed here:

#0  t_forward_nonack (t=0xb5b643a8, p_msg=0x8186258, proxy=0x0) at
t_fwd.c:774
774                                     t->uac[i].request.dst.proto =
t->uac[i].proxy->proto;

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-06-02 11:43

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Andreas,

could you try the attached patch to see if it works?

Thanks and regards,
Bogdan
File Added: blacklists.patch

----------------------------------------------------------------------

Comment By: Andreas Granig (agranig)
Date: 2007-06-02 10:52

Message:
Logged In: YES 
user_id=825350
Originator: YES

The previously attached patch only fixes segfaults for the main branch. If
there are more branches involved, it still segfaults due to NULL pointer
access. Here's the backtrace:

#0  t_forward_nonack (t=0xb5b3d890, p_msg=0x8185168, proxy=0x0) at
t_fwd.c:776
776                                     t->uac[i].request.dst.proto =
t->uac[i].proxy->proto;
(gdb) p t->uac[i].proxy
$1 = (struct proxy_l *) 0x0

That's because t->uac[i].proxy is not cloned in add_uac(...) for some
reason if DNS blacklisting is disabled. No idea how to fix that.



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1729833&group_id=139143