[OpenSER-Devel] [ openser-Bugs-1752168 ] lcr does not work with dbtext

[SourceForge.net]

Bugs item #1752168, was opened at 2007-07-11 12:28
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1752168&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.2.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Andreas Granig (agranig)
Assigned to: Nobody/Anonymous (nobody)
Summary: lcr does not work with dbtext

Initial Comment:
Hi,

LCR module checks for DB_STRING type of the gw_addr column in the gw table, but the dbtext backend returns DB_STR. Attached you can find a quick fix for 1.2.x. (I guess HEAD branch has this problem too). Please review, improve and apply.

Andreas

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-07-14 02:43

Message:
Logged In: NO 

your patch makes lcr module to accept both STRING and STR results for ip
address, because as you say dbtext returns str rather than string result. 
in my opinion better solution would be to make dbtext module return string
result, because then the code would not need to be duplicated in each
module that uses string database values.

-- juha

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1752168&group_id=139143