[OpenSER-Devel] [ openser-Bugs-1739565 ] UAC - Module: uac_replace_from in Branch-Route

[SourceForge.net]

Bugs item #1739565, was opened at 2007-06-19 11:53
Message generated for change (Settings changed) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1739565&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.2.x
Status: Open
>Resolution: Postponed
Priority: 5
Private: No
Submitted By: Carsten Bock (carstenbock)
>Assigned to: Bogdan (bogdan_iancu)
Summary: UAC - Module: uac_replace_from in Branch-Route

Initial Comment:
Happy Birthday OpenSER!

Congrutulations here from Hamburg, Germany to all OpenSER  Core Developers and thank you to all contributors to the OpenSER Project: Let's keep up the great work!

I fixed a minor Bug in OpenSER 1.2 (and earlier): uac_replace_from (Module UAC) was not proper usable in Branch-Routes (the module prohibited the use in branches and it did not work properly).
In Auto-Mode, for each branch a From-Line would be added to the Reply, resulting in multiple From-Lines in the reply. Not really a problem, just not nice.
The reason for this was, that the TM-Callback was set twice: Once when calling uac_replace_from, and the second time, when the RR-Callback was executed. When looking at the source, i did also see, that the RR-Param was also added in "manual"-Mode, which seems not to be neccessary.

The attached patch fixes the following:
- No RR-Param in manual-mode
- only single "From"-Line in replies in auto-mode
- uac_replace_from now usable in branch_routes

The patch is against OpenSER 1.2.1. I will do further testing on this patch.

Carsten

----------------------------------------------------------------------

Comment By: Bogdan (bogdan_iancu)
Date: 2007-07-06 14:12

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Carsten,

There are seversal issues with the patch:

1) in Manual mode you still need the RR-Param. If you read in the
documentation the meaning of the manual mode, you will see that it means
that all changes related to transaction are done automatically, but the
changes acros the dialog need to be done manually (and you need the
RR-param in order to restore - manual or auto - the original from in the
sequential requests)

2) if you do not not register the TM TMCB_RESPONSE_IN callback in auto
mode, the replies will not have the FROM hdr restored..

Maybe you can send me a scenario example in order to understand what you
want to do.

The support for from mangling in branch route is on purpose disabled as
there are know thinks not to work (like multiple callbacka, multipled hdrs,
etc)..

Regards,
Bogdan

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1739565&group_id=139143